filter function restore on session load #1970
Conversation
this should fix more crashes related to switching between contexts with different types of filters active. particularly when switching from a regex filtered context to a string filtered one.
| @@ -4542,6 +4543,7 @@ static bool load_session(const char *sname, char **path, char **lastdir, char ** | |||
| *path = g_ctx[cfg.curctx].c_path; | |||
| *lastdir = g_ctx[cfg.curctx].c_last; | |||
| *lastname = g_ctx[cfg.curctx].c_name; | |||
| setcfg(cfg); | |||
There was a problem hiding this comment.
How are the other 2 working without calling setcfg()? Is savecurtx() being called in some way?
There was a problem hiding this comment.
the other 2 contexts? savecurtx() should be called on any context switch, I think. I don't really like calling setcfg here, because it doesn't change the cfg assignment and set_sort_flags() already sets the other two function pointers. the important point is that the filter function pointer is set for the current context after the session is loaded. i think one of the individual commits has some more information on that
There was a problem hiding this comment.
If I am not clear, I wanted to understand how entrycmpfn and namecmpfn are being set without setcfg not being called in the current code?
loading a session or switching to a different context with a different filter mode setting (regex vs string) will not update the filter function and can lead to crashes